Upgrade EUI to `v76.3.0` by 1Copenut · Pull Request #153341 · elastic/kibana

1Copenut · 2023-03-20T22:08:29Z

Summary

eui@76.0.2 ⏩ eui@76.3.0

`76.3.0`

Updated EuiSkipLink's fallbackDestination prop to support an array of query selector strings (#6646)

Bug fixes

Fixed EuiFlyout to preserve body scrollbar width on open (#6645)
Fixed EuiImage's full screen mode to not scroll jump & to preserve body scrollbar width on open (#6645)
Fixed EuiCodeBlock's full screen mode to not scroll jump & to preserve body scrollbar width on open (#6645)

`76.2.0`

Added new renderCustomGridBody escape hatch rendering prop to EuiDataGrid (#6624)

Bug fixes

Fixed visual listbox focus ring bug on non-searchable EuiSelectables (#6637)
Added a legacy alert alias for the warning EuiIcon type (#6640)
Fixed a type definition incorrectly coming from a dev dependency, which was causing issues for some consuming projects (#6643)

`76.1.0`

Added more detailed screen reader instructions to EuiSelectable, EuiSuggest, EuiSelectableTemplateSitewide, EuiRange, and EuiDualRange. (#6589)
Added new placeholder prop to EuiSuperSelect (#6630)
Added new setCellPopoverProps parameter callback to EuiDataGrid's renderCellPopover prop (#6632)

Bug fixes

Fixed an ARIA attribute in EuiSelectableList (#6589)
Fixed EuiSelectable to no longer show active selection state or respond to the Up/Down arrow keys when focus is inside the selectable container, but not on the searchbox or listbox. (#6631)

….2.0

elasticmachine · 2023-03-22T14:50:48Z

Pinging @elastic/eui-design (EUI)

elasticmachine · 2023-03-22T16:01:37Z

Pinging @elastic/uptime (Team:uptime)

elasticmachine · 2023-03-22T16:01:38Z

Pinging @elastic/apm-ui (Team:APM)

justinkambic

Synthetics changes LGTM 👍

qn895 · 2023-03-23T19:56:40Z

...k/plugins/ml/public/application/components/controls/select_severity/select_severity.test.tsx


    // assert initial state
-    expect(getAllByText('warning')).toHaveLength(2);
+    // EuiSuperSelect was refactored to update SR-only


Suggestion to remove this comment in the code before merging

@qn895 Sure thing. I'll remove this and merge. Thank you!

I think I accidentally bumped your PR comment to a re-review. I've updated the test and CI is building again.

qn895 · 2023-03-23T20:28:05Z

ML changes LGTM 🎉

kibana-ci · 2023-03-23T20:52:59Z

💔 Build Failed

Failed CI Steps

Build and Deploy to Cloud

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fileUpload`	207	205	-2
`maps`	971	969	-2
total			-4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fileUpload`	853.4KB	852.8KB	-609.0B
`maps`	2.7MB	2.7MB	-610.0B
total			-1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	351.1KB	351.7KB	+633.0B
`kbnUiSharedDeps-css`	314.9KB	315.6KB	+655.0B
`kbnUiSharedDeps-npmDll`	5.4MB	5.4MB	+8.0KB
total			+9.2KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	433	436	+3

Total ESLint disabled count

id	before	after	diff
`securitySolution`	513	516	+3

History

💚 Build #115140 succeeded 5db87d2
💔 Build #115051 failed c49d787
💚 Build #114642 succeeded ec02495
💔 Build #114535 failed 878df13
💔 Build #114501 failed 56d8ac7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @1Copenut

## Summary eui@76.0.2 ⏩ eui@76.3.0 ## [`76.3.0`](https://github.com/elastic/eui/tree/v76.3.0) - Updated `EuiSkipLink`'s `fallbackDestination` prop to support an array of query selector strings ([elastic#6646](elastic/eui#6646)) **Bug fixes** - Fixed `EuiFlyout` to preserve body scrollbar width on open ([elastic#6645](elastic/eui#6645)) - Fixed `EuiImage`'s full screen mode to not scroll jump & to preserve body scrollbar width on open ([elastic#6645](elastic/eui#6645)) - Fixed `EuiCodeBlock`'s full screen mode to not scroll jump & to preserve body scrollbar width on open ([elastic#6645](elastic/eui#6645)) ## [`76.2.0`](https://github.com/elastic/eui/tree/v76.2.0) - Added new `renderCustomGridBody` escape hatch rendering prop to `EuiDataGrid` ([elastic#6624](elastic/eui#6624)) **Bug fixes** - Fixed visual listbox focus ring bug on non-searchable `EuiSelectable`s ([elastic#6637](elastic/eui#6637)) - Added a legacy `alert` alias for the `warning` `EuiIcon` type ([elastic#6640](elastic/eui#6640)) - Fixed a type definition incorrectly coming from a dev dependency, which was causing issues for some consuming projects ([elastic#6643](elastic/eui#6643)) ## [`76.1.0`](https://github.com/elastic/eui/tree/v76.1.0) - Added more detailed screen reader instructions to `EuiSelectable`, `EuiSuggest`, `EuiSelectableTemplateSitewide`, `EuiRange`, and `EuiDualRange`. ([elastic#6589](elastic/eui#6589)) - Added new `placeholder` prop to `EuiSuperSelect` ([elastic#6630](elastic/eui#6630)) - Added new `setCellPopoverProps` parameter callback to `EuiDataGrid`'s `renderCellPopover` prop ([elastic#6632](elastic/eui#6632)) **Bug fixes** - Fixed an ARIA attribute in `EuiSelectableList` ([elastic#6589](elastic/eui#6589)) - Fixed `EuiSelectable` to no longer show active selection state or respond to the Up/Down arrow keys when focus is inside the selectable container, but not on the searchbox or listbox. ([elastic#6631](elastic/eui#6631)) --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co>

1Copenut added 2 commits March 20, 2023 16:56

Bumping EUI package to v76.2.0.

8d5995b

Adding language translations from EUI.

34dd734

1Copenut added EUI backport:skip This PR does not require backporting ci:cloud-deploy Create or update a Cloud deployment v8.8.0 labels Mar 20, 2023

1Copenut self-assigned this Mar 20, 2023

1Copenut and others added 5 commits March 21, 2023 08:42

Merge branch 'main' into eui/v76.2.0

5f12028

Updating five unit tests for EUI changes in 76.1.0 and 76.2.0.

1367918

Merge branch 'eui/v76.2.0' of github.com:1Copenut/kibana into eui/v76…

a9f28cb

….2.0

Updating three tests for EuiSuperSelect a11y changes.

28fb701

Bumping EUI to current v76.3.0.

56d8ac7

1Copenut changed the title ~~Upgrade EUI to v76.2.0~~ Upgrade EUI to v76.3.0 Mar 21, 2023

mistic and others added 3 commits March 22, 2023 02:36

Merge branch 'main' into eui/v76.2.0

878df13

Adding cheerio to TS types.

fa724d9

Merge branch 'eui/v76.2.0' of github.com:1Copenut/kibana into eui/v76…

ec02495

….2.0

1Copenut marked this pull request as ready for review March 22, 2023 14:50

1Copenut requested review from a team as code owners March 22, 2023 14:50

1Copenut requested a review from a team March 22, 2023 14:50

1Copenut added the release_note:skip Skip the PR/issue when compiling release notes label Mar 22, 2023

jbudz approved these changes Mar 22, 2023

View reviewed changes

botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Mar 22, 2023

justinkambic approved these changes Mar 22, 2023

View reviewed changes

cnasikas approved these changes Mar 22, 2023

View reviewed changes

Bamieh approved these changes Mar 22, 2023

View reviewed changes

1Copenut and others added 2 commits March 23, 2023 10:10

Merge branch 'main' into eui/v76.2.0

c49d787

Updating 1 test for text count changes in SR-only text.

5db87d2

1Copenut requested a review from a team as a code owner March 23, 2023 18:20

dgieselaar approved these changes Mar 23, 2023

View reviewed changes

qn895 reviewed Mar 23, 2023

View reviewed changes

1Copenut and others added 2 commits March 23, 2023 15:22

Removing EUI logic comment in test.

d031c00

Merge branch 'main' into eui/v76.2.0

e4a5847

1Copenut requested a review from qn895 March 23, 2023 20:24

qn895 approved these changes Mar 23, 2023

View reviewed changes

1Copenut enabled auto-merge (squash) March 23, 2023 20:30

1Copenut merged commit 6d55dd9 into elastic:main Mar 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to `v76.3.0`#153341

Upgrade EUI to `v76.3.0`#153341
1Copenut merged 14 commits intoelastic:mainfrom
1Copenut:eui/v76.2.0

1Copenut commented Mar 20, 2023 •

edited

Loading

Uh oh!

elasticmachine commented Mar 22, 2023

Uh oh!

elasticmachine commented Mar 22, 2023

Uh oh!

elasticmachine commented Mar 22, 2023

Uh oh!

justinkambic left a comment

Uh oh!

qn895 Mar 23, 2023

Uh oh!

1Copenut Mar 23, 2023

Uh oh!

1Copenut Mar 23, 2023

Uh oh!

qn895 commented Mar 23, 2023

Uh oh!

kibana-ci commented Mar 23, 2023 •

edited

Loading

ESLint disabled line counts

Total ESLint disabled count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

1Copenut commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

76.3.0

76.2.0

76.1.0

Uh oh!

elasticmachine commented Mar 22, 2023

Uh oh!

elasticmachine commented Mar 22, 2023

Uh oh!

elasticmachine commented Mar 22, 2023

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

qn895 Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

1Copenut Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

1Copenut Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

qn895 commented Mar 23, 2023

Uh oh!

kibana-ci commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

1Copenut commented Mar 20, 2023 •

edited

Loading

`76.3.0`

`76.2.0`

`76.1.0`

kibana-ci commented Mar 23, 2023 •

edited

Loading